Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"windows" not "win32" for Windows in os.platform() possible values #2698

Closed
boan-anbo opened this issue Oct 2, 2021 · 1 comment
Closed

"windows" not "win32" for Windows in os.platform() possible values #2698

boan-anbo opened this issue Oct 2, 2021 · 1 comment

Comments

@boan-anbo
Copy link

It's windows not win32 as in the doc.

tauri/tooling/api/src/os.ts

Line 38 in 40d08a6

* The value is set at compile time. Possible values are `'aix'`, `'darwin'`, `'freebsd'`, `'linux'`, `'openbsd'`, `'sunos'`, and `'win32'`.

@boan-anbo boan-anbo changed the title "window" not "win32" for Windows in os.platform() possible values "windows" not "win32" for Windows in os.platform() possible values Oct 2, 2021
amrbashir added a commit that referenced this issue Oct 2, 2021
@amrbashir
fix(api.js): fix os.platform return on macos and windows, closes #2698
d2293fc
@amrbashir
Copy link
Member

amrbashir commented Oct 2, 2021 •
edited

Thanks for catching this, PR'd a fix now, it will return win32 as stated in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@boan-anbo @amrbashir