New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix(api): Window size and position returning wrong class (fix: #2599) #2621
Merged
lucasfernog
merged 4 commits into
tauri-apps:next
from
sirgallifrey:fix/2599-window-api-not-returning-correct-size-and-positoin-class
Sep 22, 2021
Merged
Fix(api): Window size and position returning wrong class (fix: #2599) #2621
lucasfernog
merged 4 commits into
tauri-apps:next
from
sirgallifrey:fix/2599-window-api-not-returning-correct-size-and-positoin-class
Sep 22, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I still need to do this: "A change file is added if any packages will require a version bump due to this PR per " |
changes file added |
Can you change the base branch to the |
I changed through github and now it's showing a lot of changes, I'll try rebasing, if it does not work I might create a new PR to have it clean |
…ize and PhysiscalPosition fix tauri-apps#2599
sirgallifrey
force-pushed
the
fix/2599-window-api-not-returning-correct-size-and-positoin-class
branch
from
September 21, 2021 15:40
7ad1444
to
e23edca
Compare
rebase worked like a charm |
lucasfernog
approved these changes
Sep 22, 2021
…ot-returning-correct-size-and-positoin-class
Amazing work specially the example changes, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #2599
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
The PR fulfills these requirements:
fix: #xxx[,#xxx]
, where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information:
Added the changed apis to Examples/api so that it can be used to test it in the future.
It looks like this:
Curious fact is that, for me innerSize always return the same value for a given monitor. Is that a know bug?
Also I noticed the transparent checkbox does not work, and resizable only works after changing it at least once.