Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(api): Window size and position returning wrong class (fix: #2599) #2621

Conversation

sirgallifrey
Copy link
Contributor

@sirgallifrey sirgallifrey commented Sep 21, 2021

fix #2599

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Docs
  • New Binding Issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes. Issue #___
  • No

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

Added the changed apis to Examples/api so that it can be used to test it in the future.
It looks like this:
Screen Shot 2021-09-21 at 15 39 58

Curious fact is that, for me innerSize always return the same value for a given monitor. Is that a know bug?
Also I noticed the transparent checkbox does not work, and resizable only works after changing it at least once.

@sirgallifrey sirgallifrey requested review from a team September 21, 2021 14:00
@sirgallifrey
Copy link
Contributor Author

I still need to do this: "A change file is added if any packages will require a version bump due to this PR per "

@sirgallifrey sirgallifrey requested a review from a team as a code owner September 21, 2021 14:10
@sirgallifrey
Copy link
Contributor Author

changes file added

@FabianLars
Copy link
Member

Can you change the base branch to the next branch?

@sirgallifrey sirgallifrey changed the base branch from dev to next September 21, 2021 15:34
@sirgallifrey sirgallifrey requested a review from a team September 21, 2021 15:34
@sirgallifrey
Copy link
Contributor Author

I changed through github and now it's showing a lot of changes, I'll try rebasing, if it does not work I might create a new PR to have it clean

@sirgallifrey sirgallifrey force-pushed the fix/2599-window-api-not-returning-correct-size-and-positoin-class branch from 7ad1444 to e23edca Compare September 21, 2021 15:40
@sirgallifrey
Copy link
Contributor Author

rebase worked like a charm

…ot-returning-correct-size-and-positoin-class
@lucasfernog lucasfernog merged commit cc8b146 into tauri-apps:next Sep 22, 2021
@lucasfernog
Copy link
Member

Amazing work specially the example changes, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Javascript API types incorrect when reading physical size
3 participants