fix(tauri) embedded-server edge case with config host #26
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
The PR fulfills these requirements:
dev
branch and not themaster
branchfix: #xxx[,#xxx]
, where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information:
There's an edge case for how the webview and our embeddedServer loads its URLs.
When the config -> host is set to something like
localhost
or127.0.0.1
(without http:// protocol), the server starts correctly, but the webview doesn't. We have to explicitely set the http protocol on the webview, but not on the embedded web server.So, with this PR, we add the protocol for the webview load URL if its not there, and we always remove it from the config host. With this approach, the embedded web server MUST be served locally.
There are some other changes because I ran cargofmt.