Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(cta): use commander instead of minimst #2551

Merged
merged 21 commits into from
Jan 1, 2022

Conversation

amrbashir
Copy link
Member

@amrbashir amrbashir commented Aug 29, 2021

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Docs
  • New Binding Issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes. Issue #___
  • No

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

commander is more robust than minimst, two main features I appreciate is:

  1. auto-generated help messages (kinda)
  2. validation of values passed to options

@amrbashir amrbashir requested a review from a team as a code owner August 29, 2021 20:35
@amrbashir amrbashir requested review from a team August 29, 2021 20:35
@amrbashir amrbashir changed the base branch from dev to next August 29, 2021 20:36
@amrbashir
Copy link
Member Author

alright, checks have passed, I guess this PR is ready to go

Copy link
Sponsor Member

@nothingismagick nothingismagick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will approve this, but would really like to recommend that you take the time to fill out the template of the PR and give non-informed readers (aka those not reading every channel on discord) justification for replacing functionality. This is also useful for posterity.

@amrbashir
Copy link
Member Author

yeah that's totally my bad, I think I forgot

@amrbashir amrbashir marked this pull request as draft September 22, 2021 14:34
@amrbashir
Copy link
Member Author

I marked this as a draft as I think I still need to do some changes to this PR before merge.

@amrbashir
Copy link
Member Author

alright this is ready, but probably need to be merged after the audit as it introduces a new dependency.

@amrbashir amrbashir marked this pull request as ready for review September 30, 2021 12:26
@amrbashir amrbashir marked this pull request as draft November 30, 2021 14:40
@amrbashir amrbashir marked this pull request as ready for review January 1, 2022 12:14
@amrbashir amrbashir merged commit f5e77ff into next Jan 1, 2022
@amrbashir amrbashir deleted the refactor/cta/use-commander branch January 1, 2022 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants