Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: #2508. Update dominator recipe description. #2514

Merged

Conversation

edgex004
Copy link
Contributor

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Docs
  • New Binding Issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes. Issue #___
  • No

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:
Fixes: #2508

@edgex004 edgex004 requested a review from a team as a code owner August 23, 2021 05:27
@edgex004
Copy link
Contributor Author

@amrbashir I left the description field blank for now, I considered putting in boilerplate ("A Tauri App.") , copying the window title entered by the user, or adding a new question field to the cli.

If you think any of those options are better, I can update the PR.

Copy link
Member

@amrbashir amrbashir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is fine

@lucasfernog lucasfernog changed the base branch from dev to next August 24, 2021 14:48
@lucasfernog lucasfernog merged commit 97edb3a into tauri-apps:next Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Creating a project with npm x create-tauri-app leaves description undefined, causes builds to fail
3 participants