Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove menu feature flag #2415

Merged
merged 4 commits into from Aug 13, 2021
Merged

feat: remove menu feature flag #2415

merged 4 commits into from Aug 13, 2021

Conversation

wusyong
Copy link
Member

@wusyong wusyong commented Aug 13, 2021

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Docs
  • New Binding Issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes. Issue #___
  • No

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

@wusyong wusyong requested a review from a team as a code owner August 13, 2021 09:21
@wusyong wusyong requested review from a team August 13, 2021 09:21
@amrbashir
Copy link
Member

I guess this PR closes #2248

@lucasfernog lucasfernog merged commit f81ebdd into dev Aug 13, 2021
@lucasfernog lucasfernog deleted the chore/remove-menu-flag branch August 13, 2021 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants