Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): fallback to {asset}/index.html before index.html, closes #2328 #2329

Merged
merged 3 commits into from Aug 2, 2021

Conversation

amrbashir
Copy link
Member

@amrbashir amrbashir commented Jul 31, 2021

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Docs
  • New Binding Issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes. Issue #___
  • No

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

@amrbashir amrbashir requested a review from a team July 31, 2021 15:24
@amrbashir amrbashir requested a review from a team as a code owner July 31, 2021 15:28
@amrbashir amrbashir changed the title fix(core): fallback to {asset}.html before index.html, closes 2328 fix(core): fallback to {asset}.html before index.html, closes #2328 Jul 31, 2021
@chippers
Copy link
Member

It should fall back to {asset}/index.html to follow the standard

@amrbashir
Copy link
Member Author

It should fall back to {asset}/index.html to follow the standard

yeah good point, should I add another fallback? or do you have something better in mind?

@chippers
Copy link
Member

chippers commented Jul 31, 2021

It should fall back to {asset}/index.html to follow the standard

yeah good point, should I add another fallback? or do you have something better in mind?

No, it should replace the {asset}.html as we shouldn't support that. It diverges from the rest of the web, and can break projects unexpectedly that try to output both a Tauri application + a website with the same codebase

@amrbashir amrbashir changed the title fix(core): fallback to {asset}.html before index.html, closes #2328 fix(core): fallback to {asset}/index.html before index.html, closes #2328 Jul 31, 2021
@amrbashir amrbashir changed the title fix(core): fallback to {asset}/index.html before index.html, closes #2328 fix(core): fallback to {asset}/index.html before index.html Jul 31, 2021
@amrbashir amrbashir changed the title fix(core): fallback to {asset}/index.html before index.html fix(core): fallback to {asset}/index.html before index.html, closes #2328 Jul 31, 2021
@lucasfernog lucasfernog merged commit d22da65 into dev Aug 2, 2021
@lucasfernog lucasfernog deleted the fix/core-asset-fallback branch August 2, 2021 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants