Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api.js): add nodejs-inspired functions in path module #2310

Merged
merged 20 commits into from Aug 2, 2021

Conversation

amrbashir
Copy link
Member

@amrbashir amrbashir commented Jul 28, 2021

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Docs
  • New Binding Issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

@amrbashir amrbashir requested a review from a team as a code owner July 28, 2021 16:29
@amrbashir amrbashir requested a review from a team July 28, 2021 16:29
@amrbashir
Copy link
Member Author

Alright, this PR is done, nothing more to add.

@lucasfernog lucasfernog merged commit 05b9d81 into dev Aug 2, 2021
@lucasfernog lucasfernog deleted the refactor/api-js-to-nodejs branch August 2, 2021 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants