Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(api.js): add os module #2299

Merged
merged 7 commits into from Jul 28, 2021
Merged

feat(api.js): add os module #2299

merged 7 commits into from Jul 28, 2021

Conversation

amrbashir
Copy link
Member

@amrbashir amrbashir commented Jul 27, 2021 •
edited

First step of #2233

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Docs
  • New Binding Issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes. Issue #___
  • No

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

@amrbashir amrbashir requested a review from a team as a code owner July 27, 2021 09:07
@amrbashir amrbashir requested a review from a team July 27, 2021 09:07
@amrbashir amrbashir added the scope: api.js The @tauri-apps/api npm package label Jul 28, 2021
@amrbashir
Copy link
Member Author

amrbashir commented Jul 28, 2021 •
edited

I don't know if I configured the feature flags and allowlist correctly, so double check this please.

@lucasfernog lucasfernog merged commit 05e679a into dev Jul 28, 2021
@lucasfernog lucasfernog deleted the refactor/api-js-to-nodejs branch July 28, 2021 16:17
@amrbashir amrbashir restored the refactor/api-js-to-nodejs branch July 28, 2021 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucasfernog lucasfernog lucasfernog approved these changes

@nothingismagick nothingismagick nothingismagick approved these changes

Assignees
No one assigned
Labels
scope: api.js The @tauri-apps/api npm package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@amrbashir @lucasfernog @nothingismagick