Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): Force data_directory on Windows #2288

Merged
merged 2 commits into from Jul 23, 2021
Merged

fix(core): Force data_directory on Windows #2288

merged 2 commits into from Jul 23, 2021

Conversation

lemarier
Copy link
Member

@lemarier lemarier commented Jul 23, 2021

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Docs
  • New Binding Issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes. Issue #___
  • No

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:
The check has been moved into prepare_window because prepare_pending_window is only run when it's a local URL.

Fix #2271

The check has been moved into `prepare_window` because `prepare_pending_window` is only run when it's a local url.
@lemarier lemarier requested a review from a team as a code owner July 23, 2021 13:00
@lemarier lemarier requested a review from a team July 23, 2021 13:00
@lemarier lemarier merged commit 70a1941 into dev Jul 23, 2021
@lemarier lemarier deleted the fix/data-directory branch July 23, 2021 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Local data path for Webview2 not always set
2 participants