Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix high cpu usage on mac, fix #2074 #2125

Merged
merged 2 commits into from Jun 30, 2021
Merged

Fix high cpu usage on mac, fix #2074 #2125

merged 2 commits into from Jun 30, 2021

Conversation

wusyong
Copy link
Member

@wusyong wusyong commented Jun 30, 2021

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Docs
  • New Binding Issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes. Iss looue #___
  • No

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:
Some context is being passed by clone and it is deep clone for some types such as HashMap.
This is why global shortcut manager handle went wrong and keep trigger the loop
Fix #2074

@wusyong wusyong requested a review from a team as a code owner June 30, 2021 11:18
@wusyong wusyong requested a review from a team June 30, 2021 11:18
@lemarier
Copy link
Member

I confirm that my CPU went from 100% to 0.04 and idling at 0.01.

Well done!

@lucasfernog lucasfernog merged commit a280ee9 into dev Jun 30, 2021
@lucasfernog lucasfernog deleted the fix/mac-cpu-go-brrr branch June 30, 2021 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

100% CPU consumption bug
3 participants