Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api): http ResponseType export type error #2065

Merged
merged 2 commits into from Jun 24, 2021
Merged

fix(api): http ResponseType export type error #2065

merged 2 commits into from Jun 24, 2021

Conversation

roojay520
Copy link
Contributor

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • New Binding Issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes. Issue #___
  • No

Other information:

enum ResponseType should be export as a value rather than export type when user need to config responseType of the request. If users want to import it as a type, maybe use import type { ResponseType } from '@tauri-apps/api/http'?

"@tauri-apps/api": "1.0.0-beta.1" work fine, when I upgraded to beta.2 occurred an error("ResponseType" cannot be used as a value, because i was exported using export type 1362) .
image

"@tauri-apps/api": "1.0.0-beta.2"
image

@roojay520 roojay520 requested a review from a team June 24, 2021 04:11
@roojay520 roojay520 requested a review from a team as a code owner June 24, 2021 12:01
@lucasfernog lucasfernog merged commit 394b6e0 into tauri-apps:dev Jun 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants