feat(core): add window center API, closes #1822
#1954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amrbashir
reviewed
Jun 5, 2021
| @@ -1409,6 +1423,19 @@ fn handle_event_loop( | |||
| } | |||
| } | |||
|
|
|||
| fn center_window(window: &Window) -> Result<()> { | |||
| if let Some(monitor) = window.current_monitor() { | |||
There was a problem hiding this comment.
I think this will panic or at the very least won't work, the monitor module isn't implemented for gtk yet.
There was a problem hiding this comment.
yeah it'll panic :/ the APIs are there if people wanna use on mac/windows
There was a problem hiding this comment.
Then we should mention it somewhere so people won't open issues about it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
The PR fulfills these requirements:
fix: #xxx[,#xxx], where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information: