Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Monitor if --isolatedModules is enabled #1825

Merged
merged 2 commits into from May 13, 2021

Conversation

Sporesirius
Copy link
Contributor

@Sporesirius Sporesirius commented May 13, 2021

Re-exporting a type is not possible if the flag '--isolatedModules' is provided, it requires the use of 'export type'.

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • New Binding Issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes. Issue #___
  • No

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

Re-exporting a type is not possible if the flag '--isolatedModules' is provided, it requires the use of 'export type'.
@Sporesirius Sporesirius requested a review from a team May 13, 2021 17:00
@Sporesirius Sporesirius requested a review from a team as a code owner May 13, 2021 19:52
Copy link
Member

@lucasfernog lucasfernog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if we need to keep the Monitor export for backwards compatibility, but i'll make some tests. Also, we should do the same for other interfaces.

@lucasfernog lucasfernog merged commit 9a662d2 into tauri-apps:dev May 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants