Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: CTA cache and vite build #1806

Merged
merged 10 commits into from May 12, 2021
Merged

fix: CTA cache and vite build #1806

merged 10 commits into from May 12, 2021

Conversation

jbolda
Copy link
Member

@jbolda jbolda commented May 12, 2021

What kind of change does this PR introduce? (check at least one)

This addresses some issues around npx being extra cache-y than in the past, and deals with bugs around npm and installing esbuild.

  • Bugfix
  • Feature
  • New Binding Issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes. Issue #___
  • No

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

@jbolda jbolda force-pushed the fix/cta-cache-and-vite-build branch from da121f3 to ce2937f Compare May 12, 2021 16:24
@jbolda jbolda force-pushed the fix/cta-cache-and-vite-build branch from ce2937f to a7113cc Compare May 12, 2021 16:34
@jbolda jbolda force-pushed the fix/cta-cache-and-vite-build branch from 9412d40 to 57dc7a3 Compare May 12, 2021 19:13
@jbolda jbolda marked this pull request as ready for review May 12, 2021 19:23
@jbolda jbolda requested a review from a team as a code owner May 12, 2021 19:23
@jbolda jbolda requested a review from a team May 12, 2021 19:23
@jbolda jbolda merged commit 8a164d0 into dev May 12, 2021
@jbolda jbolda deleted the fix/cta-cache-and-vite-build branch May 12, 2021 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants