Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): add default Args to all types exposing Params #1777

Merged
merged 3 commits into from May 11, 2021

Conversation

chippers
Copy link
Member

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • New Binding Issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes. Issue #___
  • No

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:
allows using no generic parameters when the user is using Builder::default().

e.g. from

#[command]
fn window_label(window: Window<impl Params<Label = String>>) {
  println!("window label: {}", window.label());
}

to

#[command]
fn window_label(window: Window) {
  println!("window label: {}", window.label());
}

Marked as draft because it's late and I haven't tested it in the slightest. The command system extensively uses type inference, so we want to make sure that this doesn't break anything. It's not a breaking change to add this PR, so we are free to do so at any time in the future. Removing it after adding it would be a breaking change, so I want to be sure that it doesn't affect command inference first.

@chippers chippers marked this pull request as ready for review May 11, 2021 17:31
@chippers chippers requested a review from a team as a code owner May 11, 2021 17:31
@chippers chippers requested review from a team May 11, 2021 17:31
@lucasfernog lucasfernog merged commit 27a7810 into dev May 11, 2021
@lucasfernog lucasfernog deleted the feat/default-params-type branch May 11, 2021 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants