Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): window menus #1745

Merged
merged 4 commits into from May 8, 2021
Merged

feat(core): window menus #1745

merged 4 commits into from May 8, 2021

Conversation

lucasfernog
Copy link
Member

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • New Binding Issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes. Issue #___
  • No

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

@lucasfernog lucasfernog requested a review from a team as a code owner May 7, 2021 23:12
@lucasfernog lucasfernog requested review from a team May 7, 2021 23:12
@lucasfernog lucasfernog marked this pull request as draft May 8, 2021 00:28
@lucasfernog
Copy link
Member Author

Converted to draft because we need to decide what to do with the keyboard accelerators.

@lucasfernog
Copy link
Member Author

Accelerators support will be added in a future release.

@lucasfernog
Copy link
Member Author

This will be hidden behind a feature flag in another PR.

@lucasfernog lucasfernog marked this pull request as ready for review May 8, 2021 14:43
@lucasfernog
Copy link
Member Author

This will be hidden behind a feature flag in another PR.

I'll also refactor the API a little bit since it's tricky to use the MenuItemId currently, and we should move the listener to the menu fn itself.

@lucasfernog lucasfernog merged commit 41d5d6a into dev May 8, 2021
@lucasfernog lucasfernog deleted the feat/menus branch May 8, 2021 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant