refactor(core): merge invoke items into single struct, allow ? #1683
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
The PR fulfills these requirements:
fix: #xxx[,#xxx]
, where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information:
Not sure if
InvokeError
andInvokeResponse
is the final abstraction to use - but we can finalize that after we get command returns using a trait. I undid most of theInvokeResponse
interface changes so that we can use?
inside of the closures. I addedInvokeError
to have an easy to use error type for it andCommandArg
. We still convert to anInvokeResponse
before formatting the callback so that we can parse the value into a json error instead of failing parsing altogether