Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core): merge invoke items into single struct, allow ? #1683

Merged
merged 4 commits into from May 3, 2021

Conversation

chippers
Copy link
Member

@chippers chippers commented May 3, 2021

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • New Binding Issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes. Issue #___
  • No (no release since the breaking change that this refactors)

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:
Not sure if InvokeError and InvokeResponse is the final abstraction to use - but we can finalize that after we get command returns using a trait. I undid most of the InvokeResponse interface changes so that we can use ? inside of the closures. I added InvokeError to have an easy to use error type for it and CommandArg. We still convert to an InvokeResponse before formatting the callback so that we can parse the value into a json error instead of failing parsing altogether

@chippers chippers requested a review from a team as a code owner May 3, 2021 00:10
@chippers chippers requested review from a team May 3, 2021 00:10
@lucasfernog lucasfernog merged commit 1d6f418 into dev May 3, 2021
@lucasfernog lucasfernog deleted the refactor/command-structs branch May 3, 2021 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants