Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): add state management, closes #1655 #1665

Merged
merged 12 commits into from May 2, 2021
Merged

Conversation

lucasfernog
Copy link
Member

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • New Binding Issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes. Issue #___
  • No

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

@lucasfernog lucasfernog requested a review from a team as a code owner April 30, 2021 17:21
@lucasfernog lucasfernog requested a review from a team April 30, 2021 17:21
Copy link
Member

@chippers chippers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks alright, except for how we pass the state into the command parameters. I have some ideas that we can discuss on discord

core/tauri-macros/src/command.rs Outdated Show resolved Hide resolved
@lucasfernog lucasfernog requested a review from a team May 1, 2021 01:36
@chippers chippers marked this pull request as draft May 1, 2021 01:36
@chippers
Copy link
Member

chippers commented May 1, 2021

I marked this as a draft because I haven't tested it personally (compiles + local tests pass) and it still needs a bit more work. I'll get around to it sometime tomorrow unless someone gets to it first

  1. Docs about the FromCommand trait
  2. remove with_window attribute from everywhere since it's completely unread
  3. test it actually works with real applications lol
  4. changefile
  5. am i missing anything?

@lucasfernog lucasfernog marked this pull request as ready for review May 1, 2021 14:09
@chippers chippers dismissed their stale review May 2, 2021 18:31

fufilled

@chippers
Copy link
Member

chippers commented May 2, 2021

Look good to me :)

@lucasfernog lucasfernog merged commit 8b6f3de into dev May 2, 2021
@lucasfernog lucasfernog deleted the feat/command-state branch May 11, 2021 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants