New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): add state management, closes #1655 #1665
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks alright, except for how we pass the state into the command parameters. I have some ideas that we can discuss on discord
I marked this as a draft because I haven't tested it personally (compiles + local tests pass) and it still needs a bit more work. I'll get around to it sometime tomorrow unless someone gets to it first
|
This reverts commit 4651bed.
Look good to me :) |
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
The PR fulfills these requirements:
fix: #xxx[,#xxx]
, where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information: