Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core): more bounds for better errors from #1623 #1632

Merged
merged 3 commits into from Apr 27, 2021

Conversation

chippers
Copy link
Member

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • New Binding Issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:
finish change file from #1623
+
adds better errors in cases where a double reference was used

error[E0277]: the trait bound `std::string::String: Borrow<&str>` is not satisfied
  --> examples/api/src-tauri/src/main.rs:23:14
   |
23 |       window.emit_all(&"rust-event", Some(0));
   |              ^^^^^^^^ the trait `Borrow<&str>` is not implemented for `std::string::String`
   |
   = help: the following implementations were found:
             <std::string::String as Borrow<str>>

@chippers chippers requested a review from a team as a code owner April 27, 2021 15:36
@chippers chippers requested a review from a team April 27, 2021 15:36
@chippers chippers changed the title refactor(core): refactor(core): more bounds for better errors from #1623 Apr 27, 2021
@lucasfernog lucasfernog merged commit a755d23 into dev Apr 27, 2021
@lucasfernog lucasfernog deleted the refactor/simplify-tags branch April 27, 2021 23:14
@chippers chippers restored the refactor/simplify-tags branch April 28, 2021 17:10
@lucasfernog lucasfernog deleted the refactor/simplify-tags branch May 11, 2021 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants