Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core): clear uri_scheme_protocol registration function names #1617

Merged
merged 6 commits into from Apr 25, 2021

Conversation

lucasfernog
Copy link
Member

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • New Binding Issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes. Issue #___
  • No

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

The current custom_protocol registration functions names will be confusing when we add deeeplink supports. This PR renames it to register_webview_protocol to be explicit. Related to #1553

@lucasfernog lucasfernog requested a review from a team April 25, 2021 13:16
@lucasfernog lucasfernog requested a review from a team as a code owner April 25, 2021 14:33
@lucasfernog lucasfernog changed the title refactor(core): clear custom_protocol registration function names refactor(core): clear uri_scheme_protocol registration function names Apr 25, 2021
@lucasfernog lucasfernog merged commit a868cb7 into dev Apr 25, 2021
@lucasfernog lucasfernog deleted the refactor/custom-protocol-fn-names branch April 25, 2021 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant