New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: #1512 #1517
Merged
Merged
fix: #1512 #1517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucasfernog
approved these changes
Apr 16, 2021
nothingismagick
approved these changes
Apr 17, 2021
Question: is there ever a reason for us to ship the TS? |
Not really, that's why we only have type definitions. :) |
amrbashir
reviewed
Apr 17, 2021
But lets merge and release |
Laegel
commented
Apr 17, 2021
nothingismagick
approved these changes
Apr 18, 2021
jbolda
reviewed
Apr 18, 2021
jbolda
reviewed
Apr 18, 2021
jbolda
approved these changes
Apr 19, 2021
jbolda
added a commit
that referenced
this pull request
Apr 19, 2021
jbolda
added a commit
that referenced
this pull request
Apr 19, 2021
jbolda
added a commit
that referenced
this pull request
Apr 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
The PR fulfills these requirements:
fix: #xxx[,#xxx]
, where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information:
I've made my tests by running and publishing to a local Verdaccio.
How the package looks like in node_modules:
An extract of my code (made with an old Vue CLI and Vue 2):
Hovering the
invoke
function displays the types as expected:Result browser-side:
With the Compotes project (see #1512):