Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #1512 #1517

Merged
merged 10 commits into from Apr 19, 2021
Merged

fix: #1512 #1517

merged 10 commits into from Apr 19, 2021

Conversation

Laegel
Copy link
Member

@Laegel Laegel commented Apr 16, 2021

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • New Binding Issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:
I've made my tests by running and publishing to a local Verdaccio.

How the package looks like in node_modules:
node_modules

An extract of my code (made with an old Vue CLI and Vue 2):
tauri-client

Hovering the invoke function displays the types as expected:
typings

Result browser-side:
vue

With the Compotes project (see #1512):
compotes

@Laegel Laegel requested a review from a team as a code owner April 16, 2021 21:19
@Laegel Laegel requested a review from a team April 16, 2021 21:19
@Laegel Laegel marked this pull request as draft April 16, 2021 21:49
@Laegel Laegel marked this pull request as ready for review April 17, 2021 08:30
@nothingismagick
Copy link
Sponsor Member

Question: is there ever a reason for us to ship the TS?

@Laegel
Copy link
Member Author

Laegel commented Apr 17, 2021

Question: is there ever a reason for us to ship the TS?

Not really, that's why we only have type definitions. :)

tooling/api/package.json Outdated Show resolved Hide resolved
@Laegel Laegel requested a review from a team April 17, 2021 19:38
@nothingismagick
Copy link
Sponsor Member

But lets merge and release

tooling/api/package.json Outdated Show resolved Hide resolved
amrbashir and others added 3 commits April 17, 2021 22:03
Co-authored-by: Laegel <valentin.chouaf@laposte.net>
.changes/config.json Outdated Show resolved Hide resolved
@jbolda jbolda merged commit fcb3b48 into dev Apr 19, 2021
@jbolda jbolda deleted the fix/api-export branch April 19, 2021 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants