Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(tauri): remove private params trait methods #1484

Merged
merged 3 commits into from Apr 14, 2021

Conversation

chippers
Copy link
Member

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • New Binding Issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes. Issue #___
  • No

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:
No more large ParamPrivate trait with a bunch of methods that are only implemented for a single type.

ParamsPrivate -> ParamsBase
ManagerPrivate -> ManagerBase
(new) Args ZST marker type. This is the type now implements Params instead of WindowManager.
App and Window now use WindowManager<P> instead of P.

@chippers chippers requested a review from a team April 14, 2021 17:16
@chippers chippers requested a review from a team as a code owner April 14, 2021 17:30
@jbolda jbolda merged commit ec27ca8 into dev Apr 14, 2021
@jbolda jbolda deleted the refactor/no-private-param-trait branch April 14, 2021 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants