Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api): Expose application metadata and functions to JS api - fix #1387 #1445

Merged
merged 5 commits into from Apr 8, 2021

Conversation

lemarier
Copy link
Member

@lemarier lemarier commented Apr 8, 2021

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • New Binding Issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes. Issue #___
  • No

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

New functions exposed to javascript API:

- getVersion
- getName
- getTauriVersion
- exit
- relaunch

Examples have been updated as well.

…n etc..

New functions exposed to javascript API:

- getVersion
- getName
- getTauriVersion
- exit
- relaunch

Examples has been updated as well.

Should close: #1387
@lemarier lemarier requested a review from a team as a code owner April 8, 2021 14:31
@lemarier lemarier requested review from a team April 8, 2021 14:31
@lucasfernog
Copy link
Member

This will conflict with #1444 but i'll deal with it.

@lucasfernog lucasfernog merged commit e511d39 into dev Apr 8, 2021
@lucasfernog lucasfernog deleted the feature/js-context-api branch April 8, 2021 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants