Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): Use Wry custom protocol instead of embedded server #1296

Merged
merged 25 commits into from Feb 26, 2021

Conversation

nklayman
Copy link
Member

@nklayman nklayman commented Feb 25, 2021

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • New Binding Issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes. Issue #___
  • No

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:
YAY! It's finally here!!!!

@nklayman nklayman requested a review from a team as a code owner February 25, 2021 00:15
@nklayman nklayman requested review from a team February 25, 2021 00:15
@lucasfernog
Copy link
Member

This still needs a fix on macOS.

tauri/src/app/webview/wry.rs Show resolved Hide resolved
tauri/src/app/webview/wry.rs Show resolved Hide resolved
tauri/src/app/utils.rs Outdated Show resolved Hide resolved
lucasfernog and others added 3 commits February 25, 2021 02:33
also remove dynamic window transparency setting as that doesn't work
@nklayman nklayman merged commit 0c691f4 into dev Feb 26, 2021
@nklayman nklayman deleted the feat/custom-protocol branch February 26, 2021 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants