Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(tauri): Webview traits #1183

Merged
merged 8 commits into from Feb 5, 2021
Merged

refactor(tauri): Webview traits #1183

merged 8 commits into from Feb 5, 2021

Conversation

lucasfernog
Copy link
Member

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • New Binding Issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

This PR changes the Tauri integration with webview to use traits instead of direct webview_official usage. This simplifies the future implementation of wry.

@lucasfernog lucasfernog requested a review from a team as a code owner February 4, 2021 03:48
@lucasfernog lucasfernog requested review from a team February 4, 2021 03:48
Copy link
Member

@wusyong wusyong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But traits method might be different when introducing wry as a dependency.

@lucasfernog lucasfernog merged commit b9ce7b9 into dev Feb 5, 2021
@lucasfernog lucasfernog deleted the feat/webview-trait branch February 5, 2021 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants