fix(tauri/asset): escape octal sequences in css #1166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nothingismagick
requested changes
Jan 30, 2021
| @@ -76,7 +76,8 @@ pub fn load( | |||
| document.getElementsByTagName("head")[0].appendChild(css); | |||
| }})(`{css}`) | |||
| "#, | |||
| css = asset_str | |||
| // Escape octal sequences, which aren't allowed in template literals | |||
| css = asset_str.replace("\\", "\\\\").as_str() | |||
There was a problem hiding this comment.
what if there are already e.g. \\\\? Wouldn't that make \\\\\\\\? or is this a non-concern?
There was a problem hiding this comment.
That is desired behavior. Since the content is being injected into a template literal, the extra slashes will be reverted back to original when the content is actually injected into the dom.
|
Okay I added it 👍. |
lucasfernog
approved these changes
Jan 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
The PR fulfills these requirements:
fix: #xxx[,#xxx], where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information:
Octal escape sequences, sometimes used for special unicode characters, are not allowed in template literals. Since Tauri's asset loader for no-server injects css into a template literal, it will throw an error if the css contains an octal sequence. This PR will replace
\with\\in css assets which will allow the octal sequence to pass through to the css without triggering a JS error.