Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Port path api to js #1006

Merged
merged 3 commits into from Sep 24, 2020
Merged

feat: Port path api to js #1006

merged 3 commits into from Sep 24, 2020

Conversation

amrbashir
Copy link
Member

@amrbashir amrbashir commented Sep 1, 2020 •
edited

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • New Binding Issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes. Issue #___
  • No

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:
Closes #929

@amrbashir amrbashir requested review from a team September 1, 2020 23:17
@jbolda
Copy link
Member

jbolda commented Sep 2, 2020

Would you please give some context behind the purpose of this PR and if it's related to prior discussion or an issue?

@amrbashir
Copy link
Member Author

The purpose it to make accessing these directories available from js side. I think it can ease the development for tauri users a bit, since they won't have to write this by themselves.

No, this is not related to prior discussion but I think there is an issue open #929 .

lucasfernog
lucasfernog requested changes Sep 15, 2020
View reviewed changes
tauri/src/endpoints.rs Outdated Show resolved Hide resolved
tauri/Cargo.toml Outdated Show resolved Hide resolved
@amrbashir
Copy link
Member Author

I pushed new changes but I am not sure if I named the endpoints and methods correctly. If you have some better names or other comments, let me know.

@amrbashir amrbashir requested a review from a team as a code owner September 24, 2020 00:30
@lucasfernog lucasfernog merged commit 771e401 into tauri-apps:dev Sep 24, 2020
amrbashir
amrbashir commented Sep 24, 2020
View reviewed changes
cli/tauri.js/api-src/path.ts
@@ -8,7 +8,8 @@ import { BaseDirectory } from './fs'
*/
async function appDir(): Promise<string> {
return await promisified<string>({
cmd: 'getDirectory',
cmd: 'resolvePath',
path: '.',
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lucasfernog this will add a "dot" to the end of the path, I believe an empty string is better.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more thing, if a base directory doesn't exist, the user will get an error like this Path Error:unable to determine base dir path. In my opinion this will confuse the user as he doesn't know the underlying api is just resolving a path using a base dir, instead it would be better to just return null like tauri's Path api in rust.

@amrbashir amrbashir deleted the port-path-api-to-js branch September 24, 2020 01:04
time-river added a commit to time-river/tauri that referenced this pull request Dec 20, 2023
@time-river
feat(wry): support proxy in wry runtime
0b79296 
wry has been supported http/socks5 proxy in
[tauri-apps#1006](tauri-apps/wry#1006), which has been
merged in [commit
3cc4d79](tauri-apps/wry@3cc4d79).

This patch aims to support its feature.

Signed-off-by: lin fu <river@vvl.me>
time-river added a commit to time-river/tauri that referenced this pull request Dec 20, 2023
@time-river
feat(wry): support proxy in wry runtime
706eb1e 
wry has been supported http/socks5 proxy in
[tauri-apps#1006](tauri-apps/wry#1006), which has been
merged in [commit
3cc4d79](tauri-apps/wry@3cc4d79).

This patch aims to support its feature.

Signed-off-by: lin fu <river@vvl.me>
time-river added a commit to time-river/tauri that referenced this pull request Dec 20, 2023
@time-river
feat(wry): support proxy in wry runtime
6780bf4 
wry has been supported http/socks5 proxy in
[tauri-apps#1006](tauri-apps/wry#1006), which has been
merged in [commit
3cc4d79](tauri-apps/wry@3cc4d79).

This patch aims to support its feature.

Signed-off-by: lin fu <river@vvl.me>
time-river added a commit to time-river/tauri that referenced this pull request Dec 21, 2023
@time-river
feat(wry): support proxy in wry runtime
1137603 
wry has been supported http/socks5 proxy in
[tauri-apps#1006](tauri-apps/wry#1006), which has been
merged in [commit
3cc4d79](tauri-apps/wry@3cc4d79).

This patch aims to support its feature.

Signed-off-by: lin fu <river@vvl.me>
time-river added a commit to time-river/tauri that referenced this pull request Dec 21, 2023
@time-river
feat(wry): support proxy in wry runtime
a6bbe35 
wry has been supported http/socks5 proxy in
[tauri-apps#1006](tauri-apps/wry#1006), which has been
merged in [commit
3cc4d79](tauri-apps/wry@3cc4d79).

This patch aims to support its feature.

Signed-off-by: lin fu <river@vvl.me>
time-river added a commit to time-river/tauri that referenced this pull request Dec 21, 2023
@time-river
feat(wry): support proxy in wry runtime
1192074 
wry has been supported http/socks5 proxy in
[tauri-apps#1006](tauri-apps/wry#1006), which has been
merged in [commit
3cc4d79](tauri-apps/wry@3cc4d79).

This patch aims to support its feature.

Signed-off-by: lin fu <river@vvl.me>
time-river added a commit to time-river/tauri that referenced this pull request Dec 25, 2023
@time-river
feat(wry): support proxy in wry runtime
fb76018 
wry has been supported http/socks5 proxy in
[tauri-apps#1006](tauri-apps/wry#1006), which has been
merged in [commit
3cc4d79](tauri-apps/wry@3cc4d79).

This patch aims to support its feature.

Signed-off-by: lin fu <river@vvl.me>
time-river added a commit to time-river/tauri that referenced this pull request Dec 29, 2023
@time-river
feat(wry): support proxy in wry runtime
7566d16 
wry has been supported http/socks5 proxy in
[tauri-apps#1006](tauri-apps/wry#1006), which has been
merged in [commit
3cc4d79](tauri-apps/wry@3cc4d79).

This patch aims to support its feature.

Signed-off-by: lin fu <river@vvl.me>
time-river added a commit to time-river/tauri that referenced this pull request Jan 3, 2024
@time-river
feat(wry): support proxy in wry runtime
601d5cf 
wry has been supported http/socks5 proxy in
[tauri-apps#1006](tauri-apps/wry#1006), which has been
merged in [commit
3cc4d79](tauri-apps/wry@3cc4d79).

This patch aims to support its feature.

Signed-off-by: lin fu <river@vvl.me>
time-river added a commit to time-river/tauri that referenced this pull request Jan 3, 2024
@time-river
feat(wry): support proxy in wry runtime
62895db 
wry has been supported http/socks5 proxy in
[tauri-apps#1006](tauri-apps/wry#1006), which has been
merged in [commit
3cc4d79](tauri-apps/wry@3cc4d79).

This patch aims to support its feature.

Signed-off-by: lin fu <river@vvl.me>
time-river added a commit to time-river/tauri that referenced this pull request Jan 3, 2024
@time-river
feat(wry): support proxy in wry runtime
76a36f3 
wry has been supported http/socks5 proxy in
[tauri-apps#1006](tauri-apps/wry#1006), which has been
merged in [commit
3cc4d79](tauri-apps/wry@3cc4d79).

This patch aims to support its feature.

Signed-off-by: lin fu <river@vvl.me>
time-river added a commit to time-river/tauri that referenced this pull request Jan 5, 2024
@time-river
feat(wry): support proxy in wry runtime
a6143be 
wry has been supported http/socks5 proxy in
[tauri-apps#1006](tauri-apps/wry#1006), which has been
merged in [commit
3cc4d79](tauri-apps/wry@3cc4d79).

This patch aims to support its feature.

Signed-off-by: lin fu <river@vvl.me>
lucasfernog added a commit that referenced this pull request Feb 1, 2024
@time-river @amrbashir @lucasfernog
feat(core): add support to setting a webview proxy, closes #4263 (#8441)
6639a57 
* feat(wry): support proxy in wry runtime

wry has been supported http/socks5 proxy in
[#1006](tauri-apps/wry#1006), which has been
merged in [commit
3cc4d79](tauri-apps/wry@3cc4d79).

This patch aims to support its feature.

Signed-off-by: lin fu <river@vvl.me>

* Apply suggestions from code review

* Apply suggestions from code review

* Update core/tauri-runtime-wry/src/lib.rs

* Update core/tauri/src/window/mod.rs

* add macos-proxy flag

* add change file

* delete file

* update change file

* use macos-14 runner to test core

---------

Signed-off-by: lin fu <river@vvl.me>
Co-authored-by: Amr Bashir <amr.bashir2015@gmail.com>
Co-authored-by: Lucas Nogueira <lucas@tauri.studio>
Co-authored-by: Lucas Nogueira <lucas@tauri.app>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucasfernog lucasfernog lucasfernog approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature][API][JS] Provide a Way to Get the Actual Paths to the Data/Config/etc. Dirs
3 participants
@amrbashir @jbolda @lucasfernog