refactor(core): return Window on create_window API (#3211)

tauri-apps · Jan 13, 2022 · e15a8af · e15a8af
1 parent d5e6046
commit e15a8af
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/.changes/create-window-return-window.md b/.changes/create-window-return-window.md
@@ -0,0 +1,5 @@
+---
+"tauri": minor
+---
+
+**Breaking change:** Return `Window` on `App` and `AppHandle`'s `create_window` function.
diff --git a/core/tauri/src/app.rs b/core/tauri/src/app.rs
@@ -372,7 +372,7 @@ macro_rules! shared_app_impl {
         label: impl Into<String>,
         url: WindowUrl,
         setup: F,
-      ) -> crate::Result<()>
+      ) -> crate::Result<Window<R>>
       where
         F: FnOnce(
           <R::Dispatcher as Dispatch>::WindowBuilder,
@@ -390,8 +390,7 @@ macro_rules! shared_app_impl {
           window_builder,
           webview_attributes,
           label,
-        ))?;
-        Ok(())
+        ))
       }
 
       #[cfg(feature = "system-tray")]