fix(core): do not serialize strings in http api form, closes #3910 (#…

…3928)
tauri-apps · Apr 20, 2022 · cc35608 · cc35608
1 parent 395a259
commit cc35608
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 5 deletions.
diff --git a/.changes/fix-form-serialization.md b/.changes/fix-form-serialization.md
@@ -0,0 +1,5 @@
+---
+"tauri": patch
+---
+
+Fixes the HTTP API form text fields.
diff --git a/.changes/remove-form-part-file.md b/.changes/remove-form-part-file.md
@@ -0,0 +1,5 @@
+---
+"tauri": patch
+---
+
+**Breaking change:** Removed `tauri::api::http::FormPart::File`.
diff --git a/core/tauri/src/api/http.rs b/core/tauri/src/api/http.rs
@@ -11,7 +11,7 @@ use serde_json::Value;
 use serde_repr::{Deserialize_repr, Serialize_repr};
 use url::Url;
 
-use std::{collections::HashMap, path::PathBuf, time::Duration};
+use std::{collections::HashMap, time::Duration};
 
 /// The builder of [`Client`].
 #[derive(Debug, Clone, Default, Deserialize)]
@@ -129,7 +129,6 @@ impl Client {
           for (name, part) in form_body.0 {
             match part {
               FormPart::Bytes(bytes) => form.push((name, serde_json::to_string(&bytes)?)),
-              FormPart::File(file_path) => form.push((name, serde_json::to_string(&file_path)?)),
               FormPart::Text(text) => form.push((name, text)),
             }
           }
@@ -176,7 +175,6 @@ impl Client {
           for (name, part) in form_body.0 {
             match part {
               FormPart::Bytes(bytes) => form.push((name, serde_json::to_string(&bytes)?)),
-              FormPart::File(file_path) => form.push((name, serde_json::to_string(&file_path)?)),
               FormPart::Text(text) => form.push((name, text)),
             }
           }
@@ -222,8 +220,6 @@ pub enum ResponseType {
 #[serde(untagged)]
 #[non_exhaustive]
 pub enum FormPart {
-  /// A file path value.
-  File(PathBuf),
   /// A string value.
   Text(String),
   /// A byte array value.