feat(api): call toString() on dialog title and message, closes #4583 (

#4588)
tauri-apps · Jul 5, 2022 · b8cd2a7 · b8cd2a7
1 parent a1d569b
commit b8cd2a7
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 9 deletions.
diff --git a/.changes/dialog-to-string.md b/.changes/dialog-to-string.md
@@ -0,0 +1,6 @@
+---
+"api": patch
+"tauri": patch
+---
+
+Use `toString()` on message/confirm/ask dialogs title and message values.
diff --git a/core/tauri/scripts/bundle.js b/core/tauri/scripts/bundle.js
diff --git a/core/tauri/scripts/core.js b/core/tauri/scripts/core.js
@@ -251,7 +251,7 @@
       __tauriModule: 'Dialog',
       message: {
         cmd: 'messageDialog',
-        message: message
+        message: message.toString()
       }
     })
   }
@@ -261,7 +261,7 @@
       __tauriModule: 'Dialog',
       message: {
         cmd: 'confirmDialog',
-        message: message
+        message: message.toString()
       }
     })
   }

diff --git a/tooling/api/src/dialog.ts b/tooling/api/src/dialog.ts
@@ -207,8 +207,8 @@ async function message(
     __tauriModule: 'Dialog',
     message: {
       cmd: 'messageDialog',
-      message,
-      title: opts?.title,
+      message: message.toString(),
+      title: opts?.title?.toString(),
       type: opts?.type
     }
   })
@@ -237,8 +237,8 @@ async function ask(
     __tauriModule: 'Dialog',
     message: {
       cmd: 'askDialog',
-      message,
-      title: opts?.title,
+      message: message.toString(),
+      title: opts?.title?.toString(),
       type: opts?.type
     }
   })
@@ -267,8 +267,8 @@ async function confirm(
     __tauriModule: 'Dialog',
     message: {
       cmd: 'confirmDialog',
-      message,
-      title: opts?.title,
+      message: message.toString(),
+      title: opts?.title?.toString(),
       type: opts?.type
     }
   })