fix(core): notification panic on Windows, closes #917 (#2011)

tauri-apps · Jun 19, 2021 · 86d0aaa · 86d0aaa
1 parent 2a5ba7f
commit 86d0aaa
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/.changes/fix-notifications-on-windows.md b/.changes/fix-notifications-on-windows.md
@@ -0,0 +1,5 @@
+---
+"tauri": patch
+---
+
+Run the `notification.show()` method on a dedicated async task to prevent a panic on Windows.
diff --git a/core/tauri/src/api/notification.rs b/core/tauri/src/api/notification.rs
@@ -81,7 +81,11 @@ impl Notification {
         notification.app_id(&self.identifier);
       }
     }
-    notification.show()?;
+
+    crate::async_runtime::spawn(async move {
+      notification.show().expect("failed to show notification");
+    });
+
     Ok(())
   }
 }