App.create_window() to accept any Into<String> type (fix #2290) (#…

…2291) * Fix `App.create_window()` to accept any `Into<String>` type * Update changefile to show both changed functions * Reduce changefile level to patch Co-authored-by: Wouter Buckens <wouter@epicteddy.com>
tauri-apps · Jul 26, 2021 · 8216cba · 8216cba
1 parent 70a1941
commit 8216cba
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 2 deletions.
diff --git a/.changes/fix-create-window-str.md b/.changes/fix-create-window-str.md
@@ -0,0 +1,5 @@
+---
+"tauri": patch
+---
+
+Change `App.create_window()` and `AppHandle.create_window()` to accept an `Into<String>` type instead of `String`.
diff --git a/core/tauri/src/app.rs b/core/tauri/src/app.rs
@@ -225,7 +225,12 @@ macro_rules! shared_app_impl {
   ($app: ty) => {
     impl<R: Runtime> $app {
       /// Creates a new webview window.
-      pub fn create_window<F>(&self, label: String, url: WindowUrl, setup: F) -> crate::Result<()>
+      pub fn create_window<F>(
+        &self,
+        label: impl Into<String>,
+        url: WindowUrl,
+        setup: F,
+      ) -> crate::Result<()>
       where
         F: FnOnce(
           <R::Dispatcher as Dispatch>::WindowBuilder,

diff --git a/examples/api/src-tauri/src/main.rs b/examples/api/src-tauri/src/main.rs
@@ -82,7 +82,7 @@ fn main() {
           }
           "new" => app
             .create_window(
-              "new".into(),
+              "new",
               WindowUrl::App("index.html".into()),
               |window_builder, webview_attributes| {
                 (window_builder.title("Tauri"), webview_attributes)