Fix: sidecar cleanup when only shell-sidecar is enabled (#4254)

Co-authored-by: Lucas Nogueira <lucas@tauri.studio>
tauri-apps · Jun 4, 2022 · 6ba9127 · 6ba9127
1 parent 2322ac1
commit 6ba9127
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/.changes/fix-sidecar-cleanup.md b/.changes/fix-sidecar-cleanup.md
@@ -0,0 +1,5 @@
+---
+"tauri": patch
+---
+
+Kill sidecar processes on app exit even when only the `shell-sidecar` feature is enabled.
diff --git a/core/tauri/src/app.rs b/core/tauri/src/app.rs
@@ -448,7 +448,7 @@ impl<R: Runtime> AppHandle<R> {
 
   /// Runs necessary cleanup tasks before exiting the process
   fn cleanup_before_exit(&self) {
-    #[cfg(shell_execute)]
+    #[cfg(any(shell_execute, shell_sidecar))]
     {
       crate::api::process::kill_children();
     }