Skip to content

Commit

Permalink
Disable version check with semver for now (#1810)
Browse files Browse the repository at this point in the history
  • Loading branch information
domiSchenk committed May 12, 2021
1 parent a68b4ee commit 66b6136
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 5 deletions.
5 changes: 5 additions & 0 deletions .changes/cli.js-package-check.md
@@ -0,0 +1,5 @@
---
"cli.js": patch
---

Packages are checked with `!=` instead of `semver` for beta releases.
Expand Up @@ -38,11 +38,11 @@ export class YarnManager implements IManager {
getLatestVersion(packageName: string): string {
const child = crossSpawnSync(
'yarn',
['info', packageName, 'versions', '--json'],
['info', packageName, 'version', '--json'],
{ cwd: appDir }
)
const output = String(child.output[1])
const packageJson = JSON.parse(output) as { data: string[] }
return packageJson.data[packageJson.data.length - 1]
const packageJson = JSON.parse(output) as { data: string }
return packageJson.data
}
}
6 changes: 4 additions & 2 deletions tooling/cli.js/src/api/dependency-manager/util.ts
Expand Up @@ -5,7 +5,7 @@
import { sync as crossSpawnSync } from 'cross-spawn'
import { resolve as appResolve } from '../../helpers/app-paths'
import { existsSync } from 'fs'
import semver from 'semver'
// import semver from 'semver'
import { IManager, NpmManager, YarnManager, PnpmManager } from './managers'

const getManager = (): IManager => {
Expand Down Expand Up @@ -60,7 +60,9 @@ function padVersion(version: string): string {
}

function semverLt(first: string, second: string): boolean {
return semver.lt(padVersion(first), padVersion(second))
return first !== second
// TODO: When version 1.0.0 is released this code should work again
// return semver.lt(padVersion(first), padVersion(second))
}

export {
Expand Down

0 comments on commit 66b6136

Please sign in to comment.