fix(api.js): fix http.fetch throwing error if response body is empty,

closes #2831 (#3008) Co-authored-by: Lucas Nogueira <lucas@tauri.studio>
tauri-apps · Dec 9, 2021 · 50c6390 · 50c6390
1 parent c664e9d
commit 50c6390
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 2 deletions.
diff --git a/.changes/api-fetch-empty-reponse.md b/.changes/api-fetch-empty-reponse.md
@@ -0,0 +1,5 @@
+---
+"api": patch
+---
+
+Fix `http.fetch` throwing error if the response is successful but the body is empty.
diff --git a/core/tauri/scripts/bundle.js b/core/tauri/scripts/bundle.js
diff --git a/tooling/api/src/http.ts b/tooling/api/src/http.ts
@@ -203,7 +203,10 @@ class Client {
           // @ts-expect-error
           response.data = JSON.parse(response.data as string)
         } catch (e) {
-          if (response.ok) {
+          if (response.ok && (response.data as unknown as string) === '') {
+            // @ts-expect-error
+            response.data = {}
+          } else if (response.ok) {
             throw Error(
               `Failed to parse response \`${response.data}\` as JSON: ${e};
               try setting the \`responseType\` option to \`ResponseType.Text\` or \`ResponseType.Binary\` if the API does not return a JSON response.`