refactor(core): change drag element detection to data attr, fixes #1656…

… (#1659)
tauri-apps · Apr 29, 2021 · 4f1e87f · 4f1e87f
1 parent df8bdcf
commit 4f1e87f
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 4 deletions.
diff --git a/.changes/drag-region-refactor.md b/.changes/drag-region-refactor.md
@@ -0,0 +1,5 @@
+---
+"tauri": patch
+---
+
+Change draggable region element detection from `drag-region` class to `data-tauri-drag-region` attribute.
diff --git a/core/tauri/scripts/core.js b/core/tauri/scripts/core.js
@@ -189,7 +189,8 @@ if (!String.prototype.startsWith) {
 
   // drag region
   document.addEventListener('mousedown', (e) => {
-    if (e.target.classList.contains('drag-region') && e.buttons === 1) {
+    // start dragging if the element has a `tauri-drag-region` data attribute
+    if (e.target.dataset.tauriDragRegion === '' && e.buttons === 1) {
       window.__TAURI__.invoke('tauri', {
         __tauriModule: "Window",
         message: {

diff --git a/examples/api/public/build/bundle.js b/examples/api/public/build/bundle.js
diff --git a/examples/api/public/build/bundle.js.map b/examples/api/public/build/bundle.js.map
diff --git a/examples/api/src/App.svelte b/examples/api/src/App.svelte
@@ -80,7 +80,7 @@
 </script>
 
 <main>
-  <div class="flex row noselect just-around" style="margin=1em;">
+  <div class="flex row noselect just-around" style="margin=1em;" data-tauri-drag-region>
     <img src="tauri.png" height="60" on:click={onLogoClick} alt="logo" />
     <div>
       <a class="dark-link" target="_blank" href="https://tauri.studio/en/docs/getting-started/intro">