Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use import in vanilla-ts fragment. #198

Merged
merged 6 commits into from Oct 1, 2022
Merged

Conversation

FabianLars
Copy link
Member

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@FabianLars
Copy link
Member Author

And that's why you test changes locally before you open a PR 💃

Copy link
Member

@amrbashir amrbashir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the reason for this? This is a vanilla template so I think imports should be from the global tauri but I am fine with the change if there is a reasonable drive behind it.

@FabianLars
Copy link
Member Author

Imo it just doesn't make sense to not use the npm package if vite (and typescript) is used, especially if we install the api package anyway.

@FabianLars
Copy link
Member Author

Oh and the "trigger" for this PR was a help thread on discord where someone was confused why we use the global object in a typescript project https://discord.com/channels/616186924390023171/625037620996734986/1025553047436406835

@amrbashir
Copy link
Member

Makes sense.

Copy link
Member

@amrbashir amrbashir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also move the api package to normal dependencies section instead of dev?

@amrbashir amrbashir merged commit dcca18c into dev Oct 1, 2022
@amrbashir amrbashir deleted the FabianLars-patch-1 branch October 1, 2022 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants