New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Use import
in vanilla-ts fragment.
#198
Conversation
And that's why you test changes locally before you open a PR 💃 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the reason for this? This is a vanilla template so I think imports should be from the global tauri but I am fine with the change if there is a reasonable drive behind it.
Imo it just doesn't make sense to not use the npm package if vite (and typescript) is used, especially if we install the api package anyway. |
Oh and the "trigger" for this PR was a help thread on discord where someone was confused why we use the global object in a typescript project https://discord.com/channels/616186924390023171/625037620996734986/1025553047436406835 |
Makes sense. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also move the api package to normal dependencies section instead of dev?
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Checklist
fix: remove a typo, closes #___, #___
)Other information