Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Angular template #167

Merged
merged 6 commits into from Sep 11, 2022
Merged

Add Angular template #167

merged 6 commits into from Sep 11, 2022

Conversation

eneajaho
Copy link
Contributor

@eneajaho eneajaho commented Sep 9, 2022

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@eneajaho eneajaho mentioned this pull request Sep 9, 2022
Closed
amrbashir
amrbashir requested changes Sep 10, 2022
View reviewed changes
Copy link
Member

@amrbashir amrbashir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this awesome PR, and sorry for the delay

packages/cli/fragments/_assets_/angular.svg Outdated Show resolved Hide resolved
packages/cli/fragments/fragment-angular/_cta_manifest_ Outdated Show resolved Hide resolved
packages/cli/fragments/fragment-angular/src/assets/tauri.svg Outdated Show resolved Hide resolved
packages/cli/fragments/fragment-angular/src/styles.scss Outdated Show resolved Hide resolved
packages/cli/fragments/fragment-angular/src/typings.d.ts Outdated Show resolved Hide resolved
@amrbashir
Copy link
Member

amrbashir commented Sep 10, 2022 •
edited

don't worry about next-ts and next failing in CI tests, I will take care of that and don't forget to run pnpm format in the repo root.

@lorenzolewis lorenzolewis mentioned this pull request Sep 10, 2022
Closed
@eneajaho
Copy link
Contributor Author

Hi @amrbashir
I pushed the changes you requested!

amrbashir
amrbashir requested changes Sep 10, 2022
View reviewed changes
Copy link
Member

@amrbashir amrbashir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

final changes before I merge. don't forget to run pnpm i then pnpm format in the repo root.

packages/cli/fragments/fragment-angular/_cta_manifest_ Outdated Show resolved Hide resolved
packages/cli/fragments/fragment-angular/package.json Outdated Show resolved Hide resolved
packages/cli/fragments/fragment-angular/angular.json Show resolved Hide resolved
packages/cli/fragments/fragment-angular/src/app/app.component.ts Outdated Show resolved Hide resolved
@eneajaho
Copy link
Contributor Author

@amrbashir All done.

@ProfeJulianLasso
Copy link

Sorry, so was it possible to support Angular in order to create apps with this framework? Thank you.

amrbashir
amrbashir approved these changes Sep 11, 2022
View reviewed changes
Copy link
Member

@amrbashir amrbashir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@amrbashir amrbashir merged commit 459228f into tauri-apps:dev Sep 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amrbashir amrbashir amrbashir approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@eneajaho @amrbashir @ProfeJulianLasso