Ig 533 coupon investigate itemable coupon history not showing #58
Conversation
[ci skip] [skip ci] Co-authored-by: Sam Poyigi <sampoyigi@users.noreply.github.com>
Signed-off-by: Sam Poyigi <6567634+sampoyigi@users.noreply.github.com>
Signed-off-by: Sam Poyigi <6567634+sampoyigi@users.noreply.github.com>
Signed-off-by: Sam Poyigi <6567634+sampoyigi@users.noreply.github.com>
rukmi-patel-it
force-pushed
the
IG-533-coupon-investigate-itemable-coupon-history-not-showing
branch
from
eaffaf4
to
e3676c8
Compare
| public function getModel() | ||
| { | ||
| } | ||
|
|
There was a problem hiding this comment.
I don't think we need to define this here as not all cartcondition will require it
There was a problem hiding this comment.
This code is required here even for all conditions other than Coupon. Removing this code would result into error as below.
There was a problem hiding this comment.
Looking at the code, getModel method is only available on the coupon cartcondition, same as appliesOnMenuItems and getApplicableItems methods. I think we should move the logic into the coupon condition since it is more specific to the coupon and not all cartconditions would have a getmodel or applicable items method
| public function getModel() | ||
| { | ||
| } | ||
|
|
There was a problem hiding this comment.
Looking at the code, getModel method is only available on the coupon cartcondition, same as appliesOnMenuItems and getApplicableItems methods. I think we should move the logic into the coupon condition since it is more specific to the coupon and not all cartconditions would have a getmodel or applicable items method
No description provided.