Improve test coverage for v4

[ryanmitchell]

These should all pass except should fail to create a location with a duplicate slug which will fail. Also the scopeListFrontEnd tests are failing due to the change from using a JSON field to a location options model - you dont seem to have set up that relation on the model - so we cant use a whereHas() type approach - what did you plan for that?

Because we're using request rules, it does mean that any changes/data applied directly to the model doesnt get checked against those validations and that seems like an oversight? Devs are likely to directly manipulate data and we should make sure its valid... do you have any thoughts on how best to approach it?

[sampoyigi]

Thanks for your patience as i am only now getting to this... I didn't add a relation to avoid breaking existing implementations that relied on the options attribute, however I've now added a safe relation for location options,

tastyigniter/TastyIgniter@652cb6e

Because we're using request rules, it does mean that any changes/data applied directly to the model doesnt get checked against those validations and that seems like an oversight? Devs are likely to directly manipulate data and we should make sure its valid... do you have any thoughts on how best to approach it?

Developers can subscribe to an event on the request rules to validate location options.