feat(python): makes RedisConnection
's close method async, use aclose
when possible
#2559
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
redis.asyncio.client.Redis.close
has been deprecated in Version5.0.1
ofredis
. Therefore,RedisConnection.close
now usesredis.asyncio.client.Redis.aclose
whenever possible. To ensure backwards compatibility,close
is still used ifaclose
is not available.More importantly,
self.conn.aclose()
will be awaited (resulting inRedisConnection.close
needing to be async). In fact, this fixesRuntimeError: Event loop stopped before Future completed.
errors I get in certain situations when trying to gracefully stop a worker by runningworker.close()
.