Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ws): try to fix result set drop stuck #329

Merged
merged 1 commit into from
Jun 3, 2024
Merged

Conversation

zitsen
Copy link
Collaborator

@zitsen zitsen commented May 14, 2024

Relates to TS-4626

@codecov-commenter
Copy link

codecov-commenter commented May 14, 2024

Codecov Report

Attention: Patch coverage is 87.91209% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 70.85%. Comparing base (a3aeee2) to head (a6cfa8e).
Report is 1 commits behind head on main.

Files Patch % Lines
taos-query/src/common/value/de/value.rs 50.00% 3 Missing ⚠️
taos-query/src/common/raw/views/mod.rs 80.00% 2 Missing ⚠️
taos-query/src/common/value.rs 0.00% 2 Missing ⚠️
taos-query/src/common/value/de/ref_value.rs 33.33% 2 Missing ⚠️
taos-query/src/common/raw/views/varbinary_view.rs 83.33% 1 Missing ⚠️
taos-ws/src/query/asyn.rs 95.45% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #329      +/-   ##
==========================================
+ Coverage   70.83%   70.85%   +0.01%     
==========================================
  Files         114      114              
  Lines       36532    36520      -12     
==========================================
- Hits        25877    25875       -2     
+ Misses      10655    10645      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

taos-ws/src/query/asyn.rs Outdated Show resolved Hide resolved
@zitsen zitsen merged commit b7728ed into main Jun 3, 2024
4 checks passed
@zitsen zitsen deleted the fix/ws-stuck-on-fetch branch June 3, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants