Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): support "rem" values on native #2539

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

ehxxn
Copy link
Member

@ehxxn ehxxn commented Apr 16, 2024

  • add rem support
  • types support ( partially done )

Copy link

vercel bot commented Apr 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
site ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 12, 2024 0:23am
studio 🔄 Building (Inspect) Visit Preview May 12, 2024 0:23am

@ehxxn ehxxn changed the title Feat/support rem em Feat/support rem Apr 16, 2024
@ehxxn ehxxn requested a review from natew April 16, 2024 14:46
@ehxxn
Copy link
Member Author

ehxxn commented Apr 16, 2024

@natew need some help with types

@ehxxn
Copy link
Member Author

ehxxn commented Apr 21, 2024

ok fixed the types

@natew
Copy link
Member

natew commented May 1, 2024

@TheEhsanSarshar can we follow this with a docs PR so we can merge once we cut the release!

We also need to add support for the types when values setting is strict!

@natew natew changed the title Feat/support rem feat(core): support "rem" values on native May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants