Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(create-tamagui): deprecate some props and move inside settings #2520

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

feat(create-tamagui): deprecate some props and move inside settings #2520

wants to merge 5 commits into from

Conversation

ehxxn
Copy link
Member

@ehxxn ehxxn commented Apr 8, 2024 •
edited

  • implement add deprecation migrations
  • Make sure onlyAllowShorhands type are working properly
  • test

List of deprecated props

  • disableRootThemeClass,
  • disableSSR,
  • maxDarkLightNesting,
  • mediaQueryDefaultActive,
  • themeClassNameOnRoot,
  • shouldAddPrefersColorThemes,
  • cssStyleSeparator
  • onlyAllowShorthands ( still a tiny issue )
  • selectionStyles
  • defaultFont

@vercel Vercel
Copy link

vercel bot commented Apr 8, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 9, 2024 1:56pm
studio 🔄 Building (Inspect) Visit Preview Apr 9, 2024 1:56pm

ehxxn
ehxxn commented Apr 9, 2024
View reviewed changes
packages/web/src/types.tsx
Comment on lines +1237 to +1239
type OnlyAllowShorthands = TamaguiSettings['onlyAllowShorthands'] extends boolean
? TamaguiSettings['onlyAllowShorthands']
: TamaguiConfig['onlyAllowShorthands']
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fallback for some reason doesn't work

@ehxxn ehxxn requested a review from natew April 9, 2024 13:18
bidah
bidah approved these changes Apr 9, 2024
View reviewed changes
apps/site/data/docs/core/configuration.mdx Outdated

<Notice>
On Android you need to set the `face` option in `createFont` or else fonts won't pick up different weights, due to a React Native restriction.
On Android you need to set the `face` option in `createFont` or else fonts
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when reading documentation I have seen that some paragraphs get cut in the middle before end. It seems that could be because of this formatting? this change shouldn't have happend right? just the same text but with a different formatting on the diff. It could be related.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah I had prettier enabled, I think prettier did that, Biome doesn't seem to support mdx

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok fixed! thanks

@natew
Copy link
Member

natew commented Apr 17, 2024

Oh for the paragraphs that's probably a regression because we changed the default text white-space to behave in-line with RN. I thought Paragraph should set it back correctly though, but either way a fix would be to not have "pre" behavior on text as I think markdown isn't supposed to be sensitive to formatting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bidah bidah bidah approved these changes

@natew natew Awaiting requested review from natew

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ehxxn @natew @bidah