Feat/moti support component config #2319
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Code looks a bit complex to me. The transform issue makes sense and should be an easy fix though. |
|
Oh sorry thought this was a PR on the moti repo |
|
But yeah I can fix this upstream |
|
thanks! |
|
@TheEhsanSarshar can you try moti 0.28.1? Should be fixed there. |
|
For shorthands, what if you just did it before the createAnimations(animations) {
const shorthands = { x: 'translateX', y: 'translateY' }
for (const animationKey in animations) {
for (const shorthand in shorthands) {
if (animations[animationKey][shorthand]) {
const styleName = shorthands[shorthand]
animations[animationKey][styleName] = animations[animationKey][shorthand]
}
}
}
return { ... }
}Then in Where |
| : props.animation | ||
| const normalizedAnimationObject = |
There was a problem hiding this comment.
lets use a for loop and a single object, should be quite a bit more performance sensitive
There was a problem hiding this comment.
same for the animationObject above probably we can do everything in one loop
|
@nandorojo for now we only have |
|
What I suggested is better |
know issues
for some reason
translateX: { type: 'spring', overshootClamping: true }doesn't work, but if I usetransforminstead it works.@nandorojo probably an issue in moti
useMotify()