feat: Added native Progress and Select implementations #2234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
andrew-levy
changed the title
andrew-levy
commented
Mar 4, 2024
Comment on lines
+444
to
+447
| if (props.native && isIos) { | ||
| return <NativeSelect {...props} /> | ||
| } | ||
|
|
There was a problem hiding this comment.
Likely can't do this naive approach. Will probably need a setup function since expo modules core is needed.
andrew-levy
commented
Mar 4, 2024
Comment on lines
+182
to
+185
| if (props.native && isIos) { | ||
| return <NativeProgress {...props} /> | ||
| } | ||
|
|
There was a problem hiding this comment.
Likely can't do this naive approach. Will probably need a setup function since expo modules core is needed.
|
I think we'd basically want to do it how we do Sheet now but even a bit further since we have the native package ourselves
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
To Do...
Progress
maxandvalueprops (I think it also supports all tamagui props but it applies it to the wrapper not the actual swiftui view... need to test this more)Screen.Recording.2024-03-04.at.9.16.42.AM.mov
Select
Select.ItemandSelect.ItemTextto pass value and label to the underlying native view.nativeTypeprop to allow the user to select betweenwheelandmenu(defaults to menu). This can be removed if we want to start simple. Can also add support for a segmented picker, just wanted to start small.Screen.Recording.2024-03-04.at.9.42.25.AM.mov