Graphql example #93
Graphql example #93
Conversation
src/article/__tests__/integration/interface/graphql/ArticleResolver.spec.ts
Outdated
Show resolved
Hide resolved
| return request() | ||
| .post('/graphql') | ||
| .send({ | ||
| operationName: 'Articles', | ||
| query: getArticlesQuery, | ||
| variables, | ||
| }) |
There was a problem hiding this comment.
What do you think about adding some abstraction to make it easier to send GraphQL calls in a test?
There was a problem hiding this comment.
I think it could be interesting. Do you have something in mind?
There was a problem hiding this comment.
I don't have the implementation per se in mind, but we could have something that would be used like this:
return query('Articles', queryArticlesQuery, variables)
.expect(async (res) => {
// ...
})And something similar to mutations as well. What do you think?
src/_lib/graphql/Graphql.d.ts
Outdated
| @@ -0,0 +1,32 @@ | |||
| import { Registry } from '@/container'; | |||
There was a problem hiding this comment.
We should avoid importing app-specific code into _lib code.
There was a problem hiding this comment.
I don't see another way to do this at the moment.
There was a problem hiding this comment.
We could move the type GraphQLContext to inside the module file since it's app-specific.
| const { findArticles } = context.container; | ||
| const { filter, pagination, sort } = args; | ||
|
|
||
| const { data: articles } = await findArticles({ filter, pagination, sort }); |
There was a problem hiding this comment.
Do you think we should add some way to pass to the query which attributes we want according to the GraphQL query?
There was a problem hiding this comment.
If I understood your question correctly I think this is up to the client to deal with/decide
There was a problem hiding this comment.
It is (and it's what is already happening), but we should also avoid fetching from the database the attributes the client does not want, right?
Overview
This PR addresses issue #89 creating a working GraphQL example
Screanshot