Finalize Update to Mojo 24.2.1 #90
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tairov
reviewed
Apr 17, 2024
llama2.mojo
Outdated
| # correct Tensor type and shape for easy reading, without copying data | ||
| var int32_ptr = DTypePointer[DType.int8](config_data_raw.steal_data().value).bitcast[DType.int32]() | ||
| var int32_ptr = config_data_raw._steal_ptr().bitcast[DType.int32]() |
There was a problem hiding this comment.
I would not return back the __steal_ptr() , since it may be removed from the future releases. Do you see any benefits of __steal_ptr() ?
There was a problem hiding this comment.
Not really, I just used it because was easier to read.
tairov
reviewed
Apr 22, 2024
| # throw away config data | ||
| _ = f.read_bytes(NUM_CONFIG_INT * sizeof[DType.int32]()) | ||
| bytes_read += NUM_CONFIG_INT * sizeof[DType.int32]() | ||
| with open(file_name, "rb") as f: |
There was a problem hiding this comment.
I wouldn't move the whole init logic under with context block. It increases cyclomatic complexity and makes harder the maintenance of this part.
|
Moved supported version to 24.3, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.