Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Popover): tabindex at 0 #3067

Closed
wants to merge 1 commit into from

Conversation

simoncdn
Copy link

@simoncdn simoncdn commented Mar 30, 2024

This PR would be fix the issue (#2951) when the popover is open the user can't focus button, inputs or others stuff inside the popover content with "tab".

Copy link

vercel bot commented Mar 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
headlessui-react ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 30, 2024 3:29pm
headlessui-vue ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 30, 2024 3:29pm

@RobinMalfait
Copy link
Collaborator

Hey!

Thanks for the PR, unfortunately this will require some more work because setting the tabindex to 0 means that it will now be focusable by the keyboard as well which has other UX implications that we don't want.

Going to close this PR for now, but I appreciate the PR!

@simoncdn
Copy link
Author

simoncdn commented Apr 5, 2024

Hello,
Sorry for my misconception about the component behavior and thank you for your feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants